Fix scalebar location validation#35
Merged
ppinard merged 1 commit intoppinard:masterfrom Jan 9, 2021
Merged
Conversation
Owner
|
My bad. I didn't know the validate functions need to return the value. Thank you for the PR. I will release a new version (0.7.1) on PyPI shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_validate_legend_locfunction in the previous PR #33 was missing a return statement so the function returnedNone.So, if we update the scalebar location using -
matplotilb.rcParams.update({"scalebar.location" : "upper right"}), it will not be updated and will be set toNoneinstead.This PR fixes that bug by adding a return statement and also adds a new test to check the rcParams updates for all
matplotlib_scalebarparameters.